Package: sponsorship-requests Severity: normal Please review my packaging branch for irqbalance/1.6.0-1 at:
https://salsa.debian.org/paride-guest/irqbalance In the beginning I thought this was going to be an easy one, it turned out not to be the case. This means that even the review won't be trivial. I implemented some opinionated choices while refactoring the package, so I expect that some discussion will take place, so don't be afraid of asking for changes or clarifications. Given that the package is widely used I'd have asked for a review even as a DD. I dropped most of the maintainer's scripts which are shipped with the irqbalance package currently in the archive. The service enablement via debconf is IMHO wrong, and indeed required overriding an Important lintian tag. The existing "oneshot" setting mechanism is buggy (try installing irqbalance 1.5.0-4 from the archive and answer Yes to the "balance all IRQs once" queston, then check /etc/default/irqbalance: the setting won't be there) and overengineered. I simplified it a lot, dropping the mechanism to inherit the "oneshot" setting from the package version in Squeeze. I think this simplification is worth the very little lack in support in an unlikely (and discouraged) upgrade scenario. The configuration file is also handled in a nicer way, making clear what debconf touched. Attached is the output of `git request-pull`. Thank you, Paride -- System Information: Debian Release: bullseye/sid APT prefers unstable-debug APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores) Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8), LANGUAGE=en_IE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled
The following changes since commit f3e6f4cb574fa495a92ff03a761ab44f2bf9e846: Open new entry in changelog (2019-06-08 10:46:37 +0000) are available in the Git repository at: https://salsa.debian.org/paride-guest/irqbalance.git for you to fetch changes up to ba4a460c0328ac667a2890970ca41af7ec0e0c0b: Update d/changelog (2019-07-18 23:02:14 +0200) ---------------------------------------------------------------- Paride Legovini (18): New upstream version 1.6.0 Drop fix-permissions-for-unix-socket.patch (unnecessary in v1.6.0) Bump compat level to 12 Hardened build (hardening=+all) Remove postinst support for ancient version 1.0.5-1 Add dep3 headers to fix-ftbs-on-hppa.patch Add Pre-Depends: ${misc:Pre-Depends} Convert d/copyright to DEP5 Add the upstream metadata file d/rules: drop override_dh_clean Bump Standards-Version to 4.4.0 (no changes needed) Drop debian-systemd-service-adaptions.patch Refactor the maintainer scripts Update the debconf PO files Drop stale variable from irqbalance.init Set myself (Paride Legovini) as Maintainer lintian-overrides: command-in-sbin-has-manpage-in-incorrect-section Update d/changelog configure.ac | 2 +- cputree.c | 22 ++++++- debian/NEWS | 15 +++++ debian/changelog | 23 +++++-- debian/control | 7 ++- debian/copyright | 36 +++++++---- debian/irqbalance.config | 71 ---------------------- debian/irqbalance.init | 1 - debian/irqbalance.lintian-overrides | 14 +++-- debian/irqbalance.postinst | 57 +++-------------- debian/irqbalance.postrm | 11 ---- debian/irqbalance.preinst | 32 ---------- debian/irqbalance.templates | 7 --- .../patches/debian-systemd-service-adaptions.patch | 34 ----------- debian/patches/fix-ftbs-on-hppa.patch | 16 +++++ .../patches/fix-permissions-for-unix-socket.patch | 40 ------------ debian/patches/series | 2 - debian/po/cs.po | 30 ++++----- debian/po/da.po | 30 ++++----- debian/po/de.po | 30 ++++----- debian/po/es.po | 30 ++++----- debian/po/eu.po | 30 ++++----- debian/po/fi.po | 30 ++++----- debian/po/fr.po | 32 ++++------ debian/po/gl.po | 30 ++++----- debian/po/it.po | 30 ++++----- debian/po/ja.po | 30 ++++----- debian/po/nl.po | 30 ++++----- debian/po/pl.po | 30 ++++----- debian/po/pt.po | 30 ++++----- debian/po/pt_BR.po | 30 ++++----- debian/po/ro.po | 42 ++++++------- debian/po/ru.po | 30 ++++----- debian/po/sv.po | 30 ++++----- debian/po/templates.pot | 23 ++----- debian/po/tr.po | 30 ++++----- debian/po/vi.po | 30 ++++----- debian/rules | 25 ++++---- debian/upstream/metadata | 5 ++ irqbalance.1 | 17 +++++- irqbalance.c | 12 ++-- irqbalance.h | 2 +- misc/irqbalance.service | 2 +- placement.c | 9 +-- procinterrupts.c | 2 +- ui/irqbalance-ui.c | 6 +- ui/irqbalance-ui.h | 2 +- 47 files changed, 402 insertions(+), 677 deletions(-) create mode 100644 debian/NEWS delete mode 100644 debian/irqbalance.postrm delete mode 100644 debian/irqbalance.preinst delete mode 100644 debian/patches/debian-systemd-service-adaptions.patch delete mode 100644 debian/patches/fix-permissions-for-unix-socket.patch create mode 100644 debian/upstream/metadata
