Control: tag -1 -moreinfo Dear Sean,
Thanks for your review! Very helpful. And I pushed my fixes to branch qa_upload2. (I removed the final releasing commit of branch qa_upload, and added update commit) Package also re-uploaded to DoM amd64 and mentors. On Tue, 18 Apr 2017 09:37:20 -0700 Sean Whitton <spwhit...@spwhitton.name> wrote: > control: tag -1 +moreinfo > > Dear Roger, > > On Mon, Apr 17, 2017 at 08:25:16PM +0900, Roger Shimizu wrote: > > I am looking for a sponsor for my package "equivs" > > Thanks for working on all these improvements and fixes. > > Here is a review of 9818bd99a15efbbbf37eace90480f69e682f2e8f: > > - Shouldn't this target experimental, not unstable, due to the freeze? I think these are all simple fix that suitable for stretch. The policy don't require pre-approval to upload to unstable [0]. If the unblock is rejected, and someone need to to fix another RC bug for this package, it's still possible since we have "testing-proposed-updates" [0]. [0] https://release.debian.org/stretch/freeze_policy.html > - In the old copyright file, there was a single list of copyright > holders, but you have generated two lists, for * and for debian/*. > How did you determine this? Based on d/changelog? I'm not sure that > is sufficiently reliable. To be safe, it might be best to just have a > "Files: *" stanza for everything -- I'm not sure. Indeed. The new d/copyright was generated by decopy. I think it's just have issue to support native package, or 1.0 source format, when I invoked decopy command. (I changed to 3.0 native afterwards) Now I merged two parts. New entries are catched by decopy, which find it in d/changelog, I think. > d/changelog: > > - You should include in the changelog that you updated the Maintainer: > field (not every QA upload does this). It's also good to write > something like (see #xxxxxx) where that's the number of the orphaning > bug. Fixed. > - You wrote "fix typos" in README.Debian, but the errors were not typos > (typos means "typographical errors"). They were just errors. So I > would suggest s/typos/minor errors/ or even s/typos/references/. Fixed. > - I think you should say that no changes were required when bumping the > std-ver in the template. > - You should say that you are bumping the debhelper compat level, not > the "debhelper version" Fixed. Hope you can sponsor this QA upload. Thank you! Cheers, -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 4096R/6C6ACD6417B3ACB1
pgpvhQlpqXOiM.pgp
Description: PGP signature
