Hi Sébastien,
On Thu, Oct 10, 2013 at 05:46:23PM +0200, s.jodo...@chu.ulg.ac.be wrote:
> I have just uploaded a Debian package for Orthanc 0.6.2 that has been
> released earlier this week [1].
I have no idea how to really test the binary packages but I surely can
verify whether the package builds or not and finally upload if it looks
OK which I can confirm so far.
> This release introduces "Orthanc Client". Orthanc Client is a SDK that allows
> a third-party software to connect to an instance of Orthanc from C++ code
> using the REST API of Orthanc. This library is built upon libcurl.
>
> I have therefore created 3 new packages: liborthancclient0.6 (the shared
> library), liborthancclient-dev (the headers), and liborthancclient-doc
> (Doxygen documentation + sample code). As this is my first packaging of a
> SDK, please could someone help me by reviewing my work to make sure the
> packaging is OK?
While I'm a bif fan of modularising binary packages and I like your step
please document it in the package changelog. It only says
* New upstream version: 0.6.2
* Fix licensing issue with the SHA-1 library. Closes: #724947
Moreover it would be better if you would use "UNRELEASED" instead of
"unstable" as target distribution to flag for others that this packaging
is not yet uploaded as actual package. I changed this when I fixed a
quite minor lintian issue with Vcs fields (I actually hate to be forced
to change these URLs but we recently faced some trouble otherwise.)
You as upstream also might like to care about
I: orthanc: spelling-error-in-binary usr/sbin/Orthanc Accesss Access
N:
N: Lintian found a spelling error in the given binary. Lintian has a list
N: of common misspellings that it looks for. It does not have a dictionary
N: like a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help
N: of gettext or a similar tool, please fix the error in the translations
N: as well as the English text to avoid making the translations fuzzy. With
N: gettext, for example, this means you should also fix the spelling
N: mistake in the corresponding msgids in the *.po files.
N:
N: You can often find the word in the source code by running:
N:
N: grep -rw <word> <source-tree>
N:
N: This tag may produce false positives for words that contain non-ASCII
N: characters due to limitations in strings.
N:
N: Severity: minor, Certainty: wild-guess
N:
N: Check: binaries, Type: binary, udeb
(You need to call lintian with -I option to see things like this.)
So please document all your changes in changelog and I will upload.
Thanks for your work on this
Andreas.
--
http://fam-tille.de
--
To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20131015150736.gp23...@an3as.eu
