Hi Otto,
On Sun, 2025-01-05 at 14:08 -0800, Otto Kekäläinen wrote:
> > I think it would be a good idea to use the script at [1] to update all
> > the Go team repos, after it's updated to account for the
> > "%{project_path}" variable, as well as replacing
> > "github.com/xanzy/go-gitlab" with its new import path.
> >
> > It also needs to be updated in dh-make-golang[2] and gophian[3], with
> > the "%{project_path}" variable again accounted for.
>
> I don't quite follow, what does "%{project_path}" have to do with line:
> > const gitlabciymlTmpl = `# auto-generated, DO NOT MODIFY.It's not only that line, it's the whole template string hardcoded within these programs. Your updates to pkg-go-tools added comments to the bottom of the template that reference this variable: # If Salsa CI is not running at # https://salsa.debian.org/%{project_path}/-/pipelines, ensure that # https://salsa.debian.org/%{project_path}/-/settings/ci_cd has in field "CI/CD # configuration file" the same filename as this file. # # If Salsa CI is running, but first job is stuck because the project doesn't # have any runners online assigned to it, ensure that # https://salsa.debian.org/%{project_path}/-/settings/ci_cd has under "Runners" # the setting for "Enable instance runners for this project" enabled. Unless we want it to remain like that the next time someone uses dh-make-golang or gophian, these tools will need to replace %{project_path} with the actual repo path so the generated file is %correct. > If you have a clear vision what to change, please file Merge Request > and assign me as reviewer, and I will dive into it and try to help you > finalize it. I've submitted a PR against dh-make-golang at [1] and have already updated gophian at [2]. > I have been drafting some code to do that in a WIP branch at > https://salsa.debian.org/otto/pkg-go-tools/-/commits/salsa-ci-plain, > but I am not finalizing it until the old MRs get reviews/approvals: > https://salsa.debian.org/go-team/infra/pkg-go-tools/-/merge_requests > > One step at a time.. I am trying to do everything so that the git HEAD > can be rolled out at any time and changes can be gradual and potential > surprising regressions easier to catch. Ack. Thanks, -- Maytham Alsudany Debian Maintainer maytham @ OFTC maytha8 @ Libera [1]: https://github.com/Debian/dh-make-golang/pull/238 [2]: https://codeberg.org/Maytha8/gophian/commit/b15a11e
signature.asc
Description: This is a digitally signed message part
