On Fri, 30 May 2025 at 10:19:19 -0300, Antonio Terceiro wrote:
On Fri, May 30, 2025 at 01:46:57PM +0100, Ahmad Khalifa wrote:
What should you do in that situation where you have a no-response MR?
Open a bug report pointing to the MR.
Or, if there is a pre-existing bug report, send mail to it pointing to
the MR.
This seems like a good opportunity to point out that for non-trivial
changes, it's often a good idea to have a bug report (or issue, or
whatever this particular project uses) *anyway*, as a place to put a
solution-neutral problem statement. The change that's being proposed is
often one of several ways to address a particular problem, and if the
maintainer is being asked to reverse-engineer the problem from the
proposed solution, that makes it harder (and more time-consuming, and
less likely to be done) to review the proposed change and assess whether
it's a good solution to the problem.
If maintainer bandwidth is the limiting factor in a particular project
(which it often is), then it's all the more important to provide a good
bug report (steps to reproduce / expected result / actual result) or a
user story for a new feature (who wants the proposed feature and why) so
that it's as easy and quick as possible for the maintainer to understand
that the proposed solution is a good one. If the maintainer needs to
invest time in asking "why do you want this change?" or "why this change
and not a different one?" then they're more likely to decide that they
don't have time to review this particular change right now, and go and
do something else instead.
smcv