* László Böszörményi (GCS) <g...@debian.org>, 2015-09-23, 22:13:
[1] http://www.barcikacomp.hu/gcs/graphicsmagick_1.3.21-4.dsc
Here's my review:
-Breaks: pdf2djvu (<= 0.7.21-2)
Dropping the Breaks is correct, but I would expect such changes to be documented in the changelog.
-Conflicts: libgraphicsmagick -Replaces: libgraphicsmagick +Conflicts: libgraphicsmagick, libgraphicsmagick3 +Replaces: libgraphicsmagick, libgraphicsmagick3
Conflicts/replaces on "libgraphicsmagick" is long obsolete and should be removed.
Conflicts/replaces on "libgraphicsmagick3" in necessary because of /usr/{lib,share}/GraphicsMagick-1.3.21/ directories. :-/ Fortunately, can make the new package co-installable with the jessie version by making conflict/replaces versioned:
Conflicts: libgraphicsmagick3 (>= 1.3.21) Replaces: libgraphicsmagick3 (>= 1.3.21)
+++ graphicsmagick-1.3.21/debian/graphicsmagick.install 2015-09-22 21:55:12.000000000 +0200 @@ -1,2 +1,3 @@ usr/bin/gm usr/share/doc/graphicsmagick/www +usr/share/man/man1/gm.1
I don't understand what why this change is needed. It's not documented in the changelog.
+++ graphicsmagick-1.3.21/debian/libgraphicsmagick++1-dev.links 2015-09-23 00:40:01.000000000 +0200 @@ -1 +1,2 @@ usr/share/doc/graphicsmagick/www/images usr/share/doc/libgraphicsmagick++1-dev/images +usr/lib/libGraphicsMagick++-Q16.so.11.0.0 usr/lib/libGraphicsMagick++-Q16.so
I don't think these symlinks are useful. If upstream build system doesn't create them, then we shouldn't either.
+++ graphicsmagick-1.3.21/debian/libgraphicsmagick1-dev.links 2015-09-23 00:23:12.000000000 +0200 @@ -1 +1,3 @@ usr/share/doc/graphicsmagick/www/images usr/share/doc/libgraphicsmagick1-dev/images +usr/lib/libGraphicsMagick-Q16.so.3.13.0 usr/lib/libGraphicsMagick-Q16.so +usr/lib/libGraphicsMagickWand-Q16.so.2.7.1 usr/lib/libGraphicsMagickWand-Q16.so
Ditto.
- dh_shlibdeps -a -L libgraphicsmagick3 \ - -l debian/libgraphicsmagick3/usr/lib + dh_shlibdeps -a -L libgraphicsmagick-q16-3 \ + -l debian/libgraphicsmagick-q16-3/usr/lib
These days -l and -L shouldn't be needed. -- Jakub Wilk
