On Tue, 14 Aug 2012 21:59:17 +0200, Sébastien Villemot wrote:

> > dpkg-source: info: local changes detected, the modified files are:
> >  ocfs2-tools-1.6.4/mkfs.ocfs2/mkfs.ocfs2.8
> >  ocfs2-tools-1.6.4/o2image/o2image.8
> >  ocfs2-tools-1.6.4/vendor/common/o2cb.init
> > which doesn't exactly match the list of files you added to d/clean :)
> The *.8 manpages are present in the original tarball, but just modified
> by the build, so I put them in ignore in d/source/options rather than
> d/clean. But they could indeed rather have been put in d/clean.

Oh, right. - Yes, d/clean might be cleaner (sic!) if they are
re-created during the build.
 
> Anyways, let's just forget about that packaging part, I don't want to
> argue.

Me neither, just trying to get it right :)
 
> >> > Hm, and what happens if ocfs2console is run with python2.6?
> >> I did not consider that possibility, given that the app is run with a
> >> #!/usr/bin/python shebang, and that the /usr/bin/python symlink is not
> >> managed by an alternative. Am I missing something?
> > No, it was me who was missing something (python details still confuse
> > me), thanks for the enlightenment!
> > And since the package has Depends: ...,  python (<< 2.8), python (>= 2.7), 
> > ...
> > we also have a safety net here.
> Then if you are convinced that this is the right fix don't hesitate to
> go with your own NMU, I cannot upload mine anyways since I'm a DM.
> Otherwise if it saves you from some work I am also willing to regenerate
> my nmudiff.

Yup, I'm happy with the solution; thanks for your offer -- as it's
quicker to just remove the patch and upload I've now put the package
in DELAYED/2.


Cheers,
gregor

 
-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Supertramp: Words Unspoken

Attachment: signature.asc
Description: Digital signature

Reply via email to