gregor herrmann <gre...@debian.org> writes: > On Sun, 12 Aug 2012 17:18:24 +0200, Sébastien Villemot wrote: >> The patch also includes fixes for packaging issues. > > This is not a good idea for an NMU for an RC bug during the freeze
The package is currently not cleaning properly (violation of policy §4.1) and not building twice in a row. While the former is clearly an RC issue, it looks like the latter is indeed not considered as such. Anyways I don't mind if these changes are not incorporated. >> diff -Nru ocfs2-tools-1.6.4/debian/changelog >> ocfs2-tools-1.6.4/debian/changelog >> --- ocfs2-tools-1.6.4/debian/changelog 2012-04-18 07:16:36.000000000 >> +0000 >> +++ ocfs2-tools-1.6.4/debian/changelog 2012-08-12 15:11:33.000000000 >> +0000 >> @@ -1,3 +1,16 @@ >> +ocfs2-tools (1.6.4-1.1) unstable; urgency=low >> + >> + * Non-maintainer upload. >> + * Remove popen2-ignore-depreciation-warn.patch: DeprecationWarnings are >> now >> + ignored by default in Python 2.7, and this patch messes things up >> + (Closes: #682517, LP: #923754) > > Hm, and what happens if ocfs2console is run with python2.6? I did not consider that possibility, given that the app is run with a #!/usr/bin/python shebang, and that the /usr/bin/python symlink is not managed by an alternative. Am I missing something? Thanks for your review, -- .''`. Sébastien Villemot : :' : Debian Maintainer `. `' http://www.dynare.org/sebastien `- GPG Key: 4096R/381A7594
pgpx41f3RKzBj.pgp
Description: PGP signature
