Your message dated Thu, 01 Oct 2009 22:38:05 +0000
with message-id <e1mtuhl-0001gd...@ries.debian.org>
and subject line Bug#547723: fixed in goobox 2.0.1-1
has caused the Debian Bug report #547723,
regarding goobox can't find CD device ("Invalid device")
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
547723: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=547723
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: goobox
Version: 2.0.0-7
Severity: grave

I get the following symptoms: The Goobox window shows the message "Invalid
device", and the following warning is printed:
  ** (goobox:1802): WARNING **: Can't read /proc/scsi/sg/device_strs

It seems Goobox assumes my CD drive is a SCSI drive because of it's
device name /dev/sr0. (It's a plain laptop ATA drive.) Next it goes
looking for that /proc file, and then it gives up when it discovers that
file doesn't exist.

This might be caused by a recent-ish kernel change, I'm pretty sure my
cd was /dev/hda when I installed this system.

I just deleted all the code that looks at the device name, and Goobox
works again for me. Patch attached. I think this won't do much damage
for people who actually have SCSI drives, goobox just won't be able to
retrieve the drive's model name anymore. It will break the "copy cd"
feature on kernel 2.4.

(BTW, the code looks for some file in /proc/ide to get the model name of
ATA device, but that's another directory I don't have here. Another
kernel change?)

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.30-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=nl_BE.UTF-8, LC_CTYPE=nl_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages goobox depends on:
ii  gconf2                     2.26.2-3      GNOME configuration database syste
ii  gnome-media                2.26.0-2      GNOME media utilities
ii  gstreamer0.10-gnomevfs     0.10.24-2     GStreamer plugin for GnomeVFS
ii  gstreamer0.10-plugins-base 0.10.24-2     GStreamer plugins from the "base" 
ii  libart-2.0-2               2.3.20-2      Library of functions for 2D graphi
ii  libatk1.0-0                1.26.0-1      The ATK accessibility toolkit
ii  libbonobo2-0               2.24.1-1      Bonobo CORBA interfaces library
ii  libbonoboui2-0             2.24.1-1      The Bonobo UI library
ii  libc6                      2.9-26        GNU C Library: Shared libraries
ii  libcairo2                  1.8.8-2       The Cairo 2D vector graphics libra
ii  libdbus-1-3                1.2.16-2      simple interprocess messaging syst
ii  libdbus-glib-1-2           0.82-1        simple interprocess messaging syst
ii  libfontconfig1             2.6.0-4       generic font configuration library
ii  libfreetype6               2.3.9-5       FreeType 2 font engine, shared lib
ii  libgcc1                    1:4.4.1-4     GCC support library
ii  libgconf2-4                2.26.2-3      GNOME configuration database syste
ii  libglade2-0                1:2.6.4-1     library to load .glade files at ru
ii  libglib2.0-0               2.20.5-1      The GLib library of C routines
ii  libgnome2-0                2.26.0-1      The GNOME library - runtime files
ii  libgnomecanvas2-0          2.26.0-1      A powerful object-oriented display
ii  libgnomeui-0               2.24.1-1      The GNOME 2 libraries (User Interf
ii  libgnomevfs2-0             1:2.24.1-4    GNOME Virtual File System (runtime
ii  libgstreamer0.10-0         0.10.24-1     Core GStreamer libraries and eleme
ii  libgtk2.0-0                2.16.6-1      The GTK+ graphical user interface 
ii  libice6                    2:1.0.5-1     X11 Inter-Client Exchange library
ii  libmusicbrainz4c2a         2.1.5-2       Second generation incarnation of t
ii  libnotify1 [libnotify1-gtk 0.4.5-1       sends desktop notifications to a n
ii  liborbit2                  1:2.14.17-0.1 libraries for ORBit2 - a CORBA ORB
ii  libpango1.0-0              1.24.5-1      Layout and rendering of internatio
ii  libpopt0                   1.14-4        lib for parsing cmdline parameters
ii  libsm6                     2:1.1.1-1     X11 Session Management library
ii  libstdc++6                 4.4.1-4       The GNU Standard C++ Library v3
ii  libx11-6                   2:1.2.2-1     X11 client-side library
ii  libxml2                    2.7.4.dfsg-2  GNOME XML library

Versions of packages goobox recommends:
ii  dbus-x11                      1.2.16-2   simple interprocess messaging syst
ii  gstreamer0.10-plugins-good    0.10.16-1  GStreamer plugins from the "good" 
ii  yelp                          2.26.0-3   Help browser for GNOME

goobox suggests no packages.

-- no debconf information
--- a/src/cd-drive.c
+++ b/src/cd-drive.c
@@ -870,7 +870,7 @@
 		if (!g_file_get_contents (filename, &line, NULL, NULL) ||
 		    line == NULL) {
 			g_free (filename);
-			return NULL;
+			return g_strdup (cdrom->device);
 		}
 		g_free (filename);
 
@@ -976,16 +976,6 @@
 static char *
 get_cd_device_file (const char *str)
 {
-	char *devname;
-	
-	if (str[0] == 's') {
-		devname = g_strdup_printf ("/dev/scd%c", str[2]);
-		if (g_file_test (devname, G_FILE_TEST_EXISTS)) {
-			g_free (devname);
-			return g_strdup_printf ("scd%c", str[2]);
-		}
-		g_free (devname);
-	}
 	return 	g_strdup (str);
 }
 
@@ -1042,17 +1032,7 @@
 		}
 	}
 
-	/* we only have to check the first char, since only ide or scsi 	
-	 * devices are listed in /proc/sys/dev/cdrom/info. It will always
-	 * be 'h' or 's'
-	 */
 	n_scsi_units = 0;
-	for (i = 0; i < n_cdroms; i++) {
-		if (cdroms[i].device[0] == 's') {
-			cdroms[i].protocol = CD_PROTOCOL_SCSI;
-			n_scsi_units++;
-		}
-	}
 
 	if (n_scsi_units > 0) {
 		/* open /dev/sg0 to force loading of the sg module if not loaded yet */

--- End Message ---
--- Begin Message ---
Source: goobox
Source-Version: 2.0.1-1

We believe that the bug you reported is fixed in the latest version of
goobox, which is due to be installed in the Debian FTP archive:

goobox_2.0.1-1.diff.gz
  to pool/main/g/goobox/goobox_2.0.1-1.diff.gz
goobox_2.0.1-1.dsc
  to pool/main/g/goobox/goobox_2.0.1-1.dsc
goobox_2.0.1-1_alpha.deb
  to pool/main/g/goobox/goobox_2.0.1-1_alpha.deb
goobox_2.0.1.orig.tar.gz
  to pool/main/g/goobox/goobox_2.0.1.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 547...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Helge Kreutzmann <deb...@helgefjell.de> (supplier of updated goobox package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 30 Sep 2009 09:11:24 +0200
Source: goobox
Binary: goobox
Architecture: source alpha
Version: 2.0.1-1
Distribution: unstable
Urgency: low
Maintainer: Helge Kreutzmann <deb...@helgefjell.de>
Changed-By: Helge Kreutzmann <deb...@helgefjell.de>
Description: 
 goobox     - CD player and ripper with GNOME 2 integration
Closes: 547723
Changes: 
 goobox (2.0.1-1) unstable; urgency=low
 .
   * New upstream release, enabling goobox to run on Debian 2.6.30 kernels at
     the cost of probably breaking goobox on (obsolete) 2.4 kernels. This
     closes: #547723. Thanks to Peter De Wachter for noticing and helping to
     track this down.
   * Update to standards version 3.8.3 (no change required)
   * Remove (all) patches - integrated upstream.
Checksums-Sha1: 
 39bd6a47e83ed0025df0ec9cef1645ff0b95ec4d 1194 goobox_2.0.1-1.dsc
 899a9927e3dd09a05f612f1774617d799c75f276 718030 goobox_2.0.1.orig.tar.gz
 5f2bb22ccca3c26632744a21534d134676768c71 18733 goobox_2.0.1-1.diff.gz
 dae327aacd1f177a74ef28519da4b40f14c8515a 322354 goobox_2.0.1-1_alpha.deb
Checksums-Sha256: 
 8910ae7c48af5a761fb4ce824a21537f2f872860bad0f55ae93ba9cfcdba0902 1194 
goobox_2.0.1-1.dsc
 25ea58ab22c712c3374810114f1574b51edf5ec2ad9e8584cb49f76ec32a6c78 718030 
goobox_2.0.1.orig.tar.gz
 0ee8ffbec7da70ef937ecbe23bbc6235f2053a81c3f51dc344bc2a12e470334a 18733 
goobox_2.0.1-1.diff.gz
 14a24bab0c6e4ab4fda1f0e9a02d593a2ff35ef363781307fd835fa9834c09bf 322354 
goobox_2.0.1-1_alpha.deb
Files: 
 d137519bf16a424d8511bb7696d0fe49 1194 gnome optional goobox_2.0.1-1.dsc
 8485450ae941c00e178ad7031b9f8503 718030 gnome optional goobox_2.0.1.orig.tar.gz
 d9617c225c0263438145ca5f963d1b31 18733 gnome optional goobox_2.0.1-1.diff.gz
 36e25c023cfc25efe320adb5ac817f37 322354 gnome optional goobox_2.0.1-1_alpha.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFKxRcGRsxcY/MYpWoRAo/RAKCXFZCfPNBjs03VuBoLitj0GuVIQgCgq3j9
SrhyCGhlOnjcITexI66xZOQ=
=A9wL
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to