Hi Clint, Thanks for these updates.
Clint Byrum wrote: > On Aug 10, 2010, at 6:36 PM, Thomas Goirand wrote: >> Hi Clint, >> >> I have made a new version of the package (both libdbi and libdbi-drivers >> 0.8.3), can you please test it? It's available here: >> >> http://ftparchive.gplhost.com/pub/libdbi/sid/ > > Thomas, thanks so much for taking the time to put this together! > > These are versioned a little funny. > > The libdbi-drivers upstream versions have a debian-like structure, so the > ones married to libdbi 0.8.3 are versioned 0.8.3-1. > > Hence, the package version is usually > > 0.8.3-1-1 > > You'll probably want to fix that before upload. Quite not! Please have a look by yourself, libdbi-drivers version isn't how you say it is: http://sourceforge.net/projects/libdbi-drivers/files/ Where exactly did you find something with 0.8.3-1 as upstream version? As much as I see, this was the case only for version 0.8.2-1 of libdbi-drivers, but that's not the case anymore (which is a good thing). > > Also you will probably want to bump the build-depend to libdbi0-dev > (>= 0.8.3). I think you didn't look correctly, because this is exactly what I did. > Actually the bash code I pasted is in error, and segfaults even with the > newer version (probably a bug in the error handling code somewhere). > > Changing DS_BASE to > > "sql//sqlite3/sqlite3_dbdir=./dbname=test.db//foo_measures/tstamp/value/derive" > > Actually makes it work even with 0.8.2 (though it breaks on Ubuntu still) If that is the case, then we don't need to release 0.8.3 right away, and I should send this new version in the experimental repository of Debian, considering that Squeeze is now in a frozen state. > Either way, I think the proper thing to do is package and release 0.8.3-1 NOT in SID/Squeeze though. You guys in Ubuntu can later import the package from Experimental. > Anyway, the items I mention above need resolving. Also I've spent a fair > amount of time getting the automated tests to run on Debian and Ubuntu, > and I *think* the attached debdiff will satisfy my issues above, and > run the automated tests during the package build. Your diff includes things that shouldn't be there which makes them unreadable because too big. I believe you should have kept source format 1.0 and just use interdiff to make this readable. Never mind, I've filtered out the upstream changes. And there's a lot of issues in what you just sent. For example: You Build-Depends on the following, and you shouldn't have: + mysql-server, mysql-client, + postgresql, postgresql-client, + locales-all | language-pack-en My package has a lot more fixes that yours doesn't add, like calling ./autogen.sh before configure, and Build-Depends: on automake and libtool, plus many others. Can you explain to me why exactly you wanted to Build-Depends on locales-all | language-pack-en? That doesn't seem to be needed, and by the way, this is Ubuntu specific, AFAIK: http://packages.debian.org/search?keywords=language-pack-en&searchon=names&suite=all§ion=all > Note that its missing these changelog entries: > > * Updated to source format "3.0 (quilt)" I don't want to use the "3.0 (quilt)" format, because when you call ./autogen.sh and ./configure, it's generating a lot of files that are in the upstream tar file. The result being that the Debian build system creates a useless huge patch in debian/patches, which shouldn't be there. Using format 1.0 solves this issue without too much work. > * Run automated tests for mysql, pgsql, sqlite, and sqlite3 I saw your tests, and I think it is a good thing to add. Could you please provide me a patch against the version that I just sent you? > * Add misc:Depends for debhelper lintian warnings. Yup. Got that one in already since the beginning. > Note that the package, with this debdiff applied, is available here: > > https://launchpad.net/~clint-fewbar/+archive/fixes/+packages I'm not willing to be rude, but your package doesn't fit, and it has still loads of lintian warnings. As it is right now, I can't use it, and my package is in a much better shape. The only thing I'd like to take from you would be the test thing (thanks a lot for that). Look at all the lintian warnings I got when using -Ii flags: I: libdbi source: binary-control-field-duplicates-source field "section" in package libdbi0 I: libdbi source: binary-control-field-duplicates-source field "section" in package libdbi0-dev W: libdbi source: obsolete-relation-form-in-source in libdbi0 conflicts: libapache2-mod-log-sql-dbi (< 1.100-11) I: libdbi source: missing-debian-source-format W: libdbi source: debhelper-but-no-misc-depends libdbi-doc W: libdbi source: debhelper-but-no-misc-depends libdbi0-dev W: libdbi source: ancient-standards-version 3.7.2 (current is 3.9.1) I: libdbi0: conflicts-with-version libapache2-mod-log-sql-dbi (<< 1.100-11) I: libdbi0: conflicts-with-version libdbd-mysql (<< 0.8.2-1) I: libdbi0: conflicts-with-version libdbd-pgsql (<< 0.8.2-1) I: libdbi0: conflicts-with-version libdbd-sqlite (<< 0.8.2-1) I: libdbi0: no-symbols-control-file usr/lib/libdbi.so.0.0.5 W: libdbi0-dev: wrong-section-according-to-package-name libdbi0-dev => libdevel these were all fixed in what I sent you. Anyway, thanks a lot for all your comments, and for pushing me to work on the package, which I would have lazily not do without you. Thomas P.S: Please send comments to #592447 only, I receive it from there as I'm the maintainer. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
