> On Sun, 07 Jun 2009, Christian Perrier wrote:
> > I'm personnally not in favor of the consistent case, here.
> > 
> > DNS, IMAP, POP, SSH, SMTP are protocol acronyms and should therefore
> > be capitalized (you'll notice that this changes the maintainer scripts
> > as well..:-))

You're absolutely right; I borked that change. Sorry about the noise.

> I was striving to use industry standard capitalization (eg DNS instead of
> Dns or dns), and where there didn't seem to be consensus, I capitalized
> the first letter. Looking at it more closely, I don't think I achieved this
> with what is there though. I don't mind changing the maintainer script
> if needed.

Ok, that's good. I have some other queries about this line though now:

> > WWW should maybe be replaced by HTTP

During review, Justin had this to say about the second question in the
template:

> Hang on - "http" isn't in /etc/services (port 80 is "www").  Will
> ufw in fact accept it?

In any case, the service in this line needs to be consistent with the
second question, I think. It's just a case of choosing which one -
services(5) has this to say:

> services  is  a  plain  ASCII  file  providing a mapping between
> human- friendly textual names for  internet  services,  and  their
> underlying assigned  port  numbers  and  protocol types.

Given that in that file www is the service and http the protocol, and
we're talking about services in this template, I think it should be www.
I'm open to constructive objections, of course :)

> Considering this, how about the following:
> - __Choices: Cups, DNS, Imap (Secure), Pop3 (Secure), SSH, Samba, Smtp, WWW, 
> WWW (Secure)
> + __Choices: CUPS, DNS, IMAP (secure), POP3 (secure), SSH, CIFS (Samba), 
> SMTP, HTTP, HTTP (secure)

Aside from the above, I agree.


-- 
Jonathan Wiltshire

PGP/GPG: 0xDB800B52 / 4216 F01F DCA9 21AC F3D3  A903 CA6B EA3E DB80 0B52

Attachment: signature.asc
Description: Digital signature

Reply via email to