* Christian Perrier <[EMAIL PROTECTED]> [2008-06-29 08:11]:
> > +# configured so it will boot from disk
> > +# :sl4:
> > +_Description: Configuring system to make it bootable
>
> If this is displayed in a progress bar, it should have an ellipsis:
No, this is the title of the progress bar.
Anyway, should I change it to "Making the system bootable" to make it
shorter?
> > +Template: flash-kernel-installer/generating_image
> > +Type: text
> > +# This is a progress bar showing up when the system generates a
> > +# special boot image on disk for some embedded device so they
> > +# can boot.
> > +# :sl4:
> > +_Description: Generating boot image on disk
> Ditto.
Yes, here I need the ellipsis.
None of the progress bars in flash-kernel use an ellipsis at the
moment. Can you add it without destroying all translations or does
updating the translations for this require knowledge of the language?
> > -_Description: Configure flash memory to boot the system
> > +_Description: Configure system to make it bootable
> Seems fairs. However, I somewhat fear that it might be hard for some
> translators to fit in about 60 columns (the limit for main menu items:
> otherwise, the title is cut).
>
> Would "Make the system bootable" be acceptable?
Yes, sounds good to me.
Here is my new patch. Is this ok?
Index: debian/control
===================================================================
--- debian/control (revision 53941)
+++ debian/control (working copy)
@@ -28,4 +28,4 @@
Provides: bootable-system
Depends: cdebconf-udeb, installed-base
XB-Installer-Menu-Item: 7300
-Description: Configure flash to boot the system
+Description: Make the system bootable
Index: debian/flash-kernel-installer.templates
===================================================================
--- debian/flash-kernel-installer.templates (revision 53940)
+++ debian/flash-kernel-installer.templates (working copy)
@@ -1,10 +1,17 @@
Template: flash-kernel-installer/progress
Type: text
-# This item is a progress bar item when the system configures
+# This item is a progress bar heading when the system configures
# some flashable memory used by many embedded devices
# :sl4:
_Description: Configuring flash memory to boot the system
+Template: flash-kernel-installer/progress_disk
+Type: text
+# This item is a progress bar heading when an embedded device is
+# configured so it will boot from disk
+# :sl4:
+_Description: Making the system bootable
+
Template: flash-kernel-installer/prepare
Type: text
# This is "preparing the system" to flash the kernel and initrd
@@ -19,6 +26,14 @@
# :sl4:
_Description: Writing the kernel to flash memory
+Template: flash-kernel-installer/generating_image
+Type: text
+# This is a progress bar showing up when the system generates a
+# special boot image on disk for some embedded device so they
+# can boot.
+# :sl4:
+_Description: Generating boot image on disk...
+
Template: debian-installer/flash-kernel-installer/title
Type: text
# Main menu item
@@ -26,4 +41,4 @@
# the flashable memory used by many embedded devices
# (writing the kernel and initrd to it)
# :sl4:
-_Description: Configure flash memory to boot the system
+_Description: Make the system bootable
Index: debian/flash-kernel-installer.postinst
===================================================================
--- debian/flash-kernel-installer.postinst (revision 53957)
+++ debian/flash-kernel-installer.postinst (working copy)
@@ -19,8 +19,25 @@
mount | grep "on /target${1%/} " | cut -d' ' -f1
}
+# Are we writing to flash or constructing an image on disk?
+write_to_flash() {
+ case "$machine" in
+ "HP Media Vault mv2120")
+ return 1
+ ;;
+ *)
+ return 0
+ ;;
+ esac
+}
-db_progress START 0 2 flash-kernel-installer/progress
+machine=$(grep "^Hardware" /proc/cpuinfo | sed 's/Hardware\s*:\s*//')
+
+if write_to_flash; then
+ db_progress START 0 2 flash-kernel-installer/progress
+else
+ db_progress START 0 2 flash-kernel-installer/progress_disk
+fi
db_progress INFO flash-kernel-installer/prepare
if ! apt-install flash-kernel; then
@@ -33,7 +50,6 @@
/target/etc/kernel-img.conf
fi
-machine=$(grep "^Hardware" /proc/cpuinfo | sed 's/Hardware\s*:\s*//')
case "$machine" in
"HP Media Vault mv2120")
in-target update-initramfs -u || true
@@ -79,7 +95,11 @@
esac
db_progress STEP 1
-db_progress INFO flash-kernel-installer/flashing
+if write_to_flash; then
+ db_progress INFO flash-kernel-installer/flashing
+else
+ db_progress INFO flash-kernel-installer/generating_image
+fi
# We need the udev /dev which has the MTD devices
mount -o bind /dev /target/dev
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
