On Thu, Jul 17, 2008 at 10:45:04PM +0200, Frans Pop wrote: > On Thursday 17 July 2008, Ryan Niebur wrote: > > Here is a patch that adds support for RAID6 and RAID10 to the debian > > installer. > > Thanks a lot.
Indeed!
> You seem to have moved two functions in that patch which have remained
> more or less the same. This makes review more difficult then it should
> be.
>
> Could you please submit a patch that contains only the actual functional
> changes? And if you think the move is needed, then do that in a separate
> patch first or after without any changes in the functions?
To ask a little bit further: could you do the refactoring in a separate
patch than in the one you add support for RAID6 and RAID10?
> I think we should certainly consider this for Lenny. Main bottleneck
> will be the translation effort required.
I agree that it would be a suitable inclusion for Lenny, from this first
look. But I also want to see the bug fixed in my "md-love" branch
included [1], and surely Ryan's patch would need some small changes to
cope with it.
[1] Last patch sent with Message-ID: <[EMAIL PROTECTED]>
Cheers,
--
Jérémy Bobbio .''`.
[EMAIL PROTECTED] : :Ⓐ : # apt-get install anarchism
`. `'`
`-
signature.asc
Description: Digital signature
