Hi Dan, Thanks for your advise. I thought that mailing list here would the right channel to communicate thoughts/ideas and getting suggestion in return.
I have pushed my changes and did a pull request. I hope nobody feels offended by doing it in this way. I am open for comments and suggestions. So please let me know what to enhance. Best regards, Mario 2018-04-16 21:50 GMT+02:00 Dan Torop <d...@pnym.net>: > Hi Mario, > > Thank you! You should also, certainly, chat with the darktable developers > (IRC?) before going too far. They've been clear in the past that they don't > want someone putting in lots of work on a feature if they don't think it'll > make it in, or make it in in the initial form. I'd be curious as to their > thoughts on how custom image sorting could work... > > Dan > > > > On Mon, Apr 16, 2018, at 3:47 PM, Mario Lüder wrote: > > Hi Dan, > > thanks for your suggestion and your interest. > > To your suggestion > > Perhaps a simpler version is best: sort order associated not with a > particular "collect images" filter but as another column in the "images" > table. This would cause less worry about a lengthy join and indexing on a > TEXT column in "custom_image_order". And once "places|beach" is given a > custom sequence, it will maintain that even if the collection is further > filtered. And somewhat maintain that sequence for other collections which > overlap it. This would also not leave "ghost" custom image orders laying > order when a tag or film roll is deleted. On the other hand, it wouldn't > allow for creating tags "sequence|v1" and then "sequence|v2" with utterly > different orders. > > > I like your idea to simplify it. So I will implement it that way. First a > version without the tags. > > Worth updating https://redmine.darktable.org/issues/9641 with a note of > your progress/interest, to add to the record. Easier to search redmine than > the mailing list. > > > I'll check that. > > Thanks again and best regards, > Mario > > > > > > > ___________________________________________________________________________ > darktable developer mailing list to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org > > > > ___________________________________________________________________________ > darktable developer mailing list to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
