Hi Jefferson, hi Heiko, Jefferson, thanks for pointing that out. I have fixed that issue.
Heiko, I have done a pull request for my change. See: https://github.com/darktable-org/darktable/pull/1677 So, I am (eagerly :-) ) wait for for your response - It would be helpful for me to get your feedback soon as I am now a bit familiar with darktable code. Best regards, Mario 2018-04-16 16:16 GMT+02:00 Jefferson Ferreira <jeffer...@mopa.tv>: > Hello, > > I tested your patch and works well. But, I am having problems to use the > module "White Balance" with option "Spot" activated. The darktable think > that I am trying to mode the image. > > Best regards. > 2018-04-16 9:55 GMT+02:00 Heiko Bauke <heiko.ba...@mail.de>: > Hi, > > Am 15.04.2018 um 22:16 schrieb Mario Lüder: > >> Thanks for your interest. You may find my patch attached. >> > > looks interesting and potentially useful. > > I think the canonical way to contribute code to draktabe is to open a pull > request on github, see https://github.com/darktable-org/darktable/ > To get something into darktable, it is not sufficient to implement a > useful feature. Darktable core developers also consider code quality. > Be patient if your pull request is not merged immediately into darktable. > After you have opened a pull request wait for feedback and try to respond > in a constructive manner to comments and criticism. > > > Heiko > > > -- > -- Number Crunch Blog @ https://www.numbercrunch.de > -- Cluster Computing @ https://www.clustercomputing.de > -- Professional @ https://www.mpi-hd.mpg.de/personalhomes/bauke > -- Social Networking @ https://www.researchgate.net/profile/Heiko_Bauke > ____________________________________________________________ > _______________ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscribe@list > s.darktable.org > > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
