Hi Mario, The patch looks sympathetic with the spirit of the darktable code, and you've clearly gotten deep into the code. A query, from reading it through (I haven't run it), is about sort order depending upon the setting of "collect images" as a string:
- What if the user filters the images by tags "places|beach" and "darktable|printed|%", and hand-sorts that collection. Then some other day the user reverses this filter (by "darktable|printed|%" and "places|beach"). The same images will display, but the sort order is lost. - Similarly, what if the user filters the images by "places|beach" and makes a good sequence. Then they sub-filter by narrowing down to "darktable|printed|%". The sort order is now lost. I wonder what the ideal behavior is here. Should each tag, film roll, etc. have its own potential custom sort order, and should successive filtering via "collect images" have no result on that order, hence only the first chosen filter (or the first chosen filter with a custom order) matter? Perhaps a simpler version is best: sort order associated not with a particular "collect images" filter but as another column in the "images" table. This would cause less worry about a lengthy join and indexing on a TEXT column in "custom_image_order". And once "places|beach" is given a custom sequence, it will maintain that even if the collection is further filtered. And somewhat maintain that sequence for other collections which overlap it. This would also not leave "ghost" custom image orders laying order when a tag or film roll is deleted. On the other hand, it wouldn't allow for creating tags "sequence|v1" and then "sequence|v2" with utterly different orders. To add to what Heiko wrote about contributing code: - Worth updating https://redmine.darktable.org/issues/9641 with a note of your progress/interest, to add to the record. Easier to search redmine than the mailing list. - It's highly recommended to visit irc.freenode.net, channel #darktable to check in with developers. A great way for them to get a sense of what you're up to, and for you to get a sense of their interests/concerns. And to echo, making a PR is a great way to put your code on-the-record and allow a forum there for discussion/improvement. I'm another who came to darktable hoping to find a way to reorder images. My work-around finally ended up being using the print module to make 4x6 work prints, and to arrange those images on a table. This works quite well, though of course requires more resources. I'd be thrilled if your work turns into a good way to resequence images in lighttable. Regards, Dan On Mon, Apr 16, 2018, at 3:55 AM, Heiko Bauke wrote: > Hi, > > Am 15.04.2018 um 22:16 schrieb Mario Lüder: > > Thanks for your interest. You may find my patch attached. > > looks interesting and potentially useful. > > I think the canonical way to contribute code to draktabe is to open a > pull request on github, see https://github.com/darktable-org/darktable/ > To get something into darktable, it is not sufficient to implement a > useful feature. Darktable core developers also consider code quality. > Be patient if your pull request is not merged immediately into > darktable. After you have opened a pull request wait for feedback and > try to respond in a constructive manner to comments and criticism. > > > Heiko > > > -- > -- Number Crunch Blog @ https://www.numbercrunch.de > -- Cluster Computing @ https://www.clustercomputing.de > -- Professional @ https://www.mpi-hd.mpg.de/personalhomes/bauke > -- Social Networking @ https://www.researchgate.net/profile/Heiko_Bauke > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
