Hi Dan, To come back briefly on the profiling.
After two passes there are indeed no further visible improvements in image quality. With two passes and some more minor tweaking I’m now at 7.6 seconds with my not too spectacular laptop hardware. I also tried DCI for red and blue reconstruction once the green is there, but it didn’t look good at all. More false colour artifacts. Cheers, Ingo > Am 08.02.2016 um 23:52 schrieb Dan Torop <d...@pnym.net>: > > Hi Ingo, > > This is quite interesting work to see... A x-trans demosaic algorithm > which is well described, high quality, open source, and fast is > something which I'm sure many people are awaiting. Though of course > having all of these qualities is a lot to ask! It's great to see > continued work on this, and in particular addressing the color > artifacts. > > How does the speed of your code when hooked into dcraw compare to 1-pass > or 3-pass Markesteijn via dcraw? The dt version of Markesteijn is about > 2-3x faster than dcraw's, if I recall right, but dcraw's Markesteijn > could still be a good basis of comparison. > > How much work would it be to make a CPU variant? So far as I know, all > of darktable is built to function on CPUs with the possibility of GPU > speed-up in certain cases. > > I can't speak for the dt core developers regarding their interest & > priorities, of course... > > Best, > Dan > > > > On Mon, Feb 8, 2016, at 03:42 PM, Ingo Liebhardt wrote: >> Hi all, >> >> Congrats to version 2.0.1. >> >> Would you maybe be interested in an alternative approach to the Markesteijn >> x-trans demosaicing? >> >> I see that for Bayer patterns you have a fast one, plus two different >> high-quality ones (AMaZE and VNG4). >> >> The only high-quality one for x-trans seems to be Markesteijn. >> I personally find that Markesteijn is producing very sharp results, but also >> quite some false colour artifacts. >> I’ve been playing around with an alternative approach, and I’m slowly >> starting to get reasonable results. (even images with lots of green - always >> problematic - start looking okay(ish)). >> >> If you want to have a look: >> https://github.com/ILiebhardt/xtrans >> >> And some sample comparisons to Markesteijn, plus a brief explanation of the >> idea: >> https://www.storehouse.co/stories/b8sj2 >> >> Don’t be mistaken by my version number: there’s still a lot of work to be >> done, and I also still have quite some ideas for improvements… >> >> So at this stage I just want to carefully pre-inquire if there could be some >> interest, in principle. >> >> Thanks a lot for letting me know. >> >> Cheers, >> Ingo >> >> >> >> ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org > >> > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
