Sorry, click on the wrong button and send a private mail to Corinna... :-)
-----Original Message----- From: Bernard Dautrevaux [mailto:[EMAIL PROTECTED]] Sent: Wednesday, March 06, 2002 6:15 PM To: 'Corinna Vinschen' Subject: RE: Suggestion for setup > -----Original Message----- > From: Corinna Vinschen [mailto:[EMAIL PROTECTED]] > Sent: Wednesday, March 06, 2002 6:03 PM > To: [EMAIL PROTECTED] > Subject: Re: Suggestion for setup > > > On Wed, Mar 06, 2002 at 11:43:47AM -0500, Chris Faylor wrote: > > On Wed, Mar 06, 2002 at 04:32:24PM +0100, Corinna Vinschen wrote: > > >On Wed, Mar 06, 2002 at 03:01:05PM +0100, Bernard Dautrevaux wrote: > > >> As this is quite a simple patch, I proceed and here it > is, for mkgroup.c and > > >> mkpasswd.c: > > > > > >I have two problems with this patch: > > > > > >- No ChangeLog entry. > > >- Do we have a signed copyright assignment from you? > > > > The patch also seemed to have some strange characters in > it, at least on my > > system. > > Right, I'm seeing these pipe characters: > > *************** > *** 379,382 **** > --- 381,386 ---- > | switch (i) > | { > + | case 'a': > + | print_domain = -1; > | case 'l': > | print_local = 1; > > You too? > Don't know from where these can come; in my copy here I got: *************** *** 379,382 **** --- 381,386 ---- switch (i) { + case 'a': + print_domain = -1; case 'l': print_local = 1; I attach the original file below; the Changelog entry could be: 2002-03-06 Bernard Dautrevaux <[EMAIL PROTECTED]> * mkgroup.c: Add a '-a' option to generate both local and domain groups, but without complaining if we cannot found a domain controller (i.e. if we're in a workgroup instead of a domain). * mkpasswd.c: ditto, but for users As for a copyright assignment, I thought the change was sufficiently small to not need one; the "contributing" page says we need one if the "change is going to be a significant one in terms of the size of your code changes". I hope changing about 10 lines in two files is not considered a "significant" change but rather a minor one. I would *really* prefer not having to go through all the paperwork (something I may even have to decline due to our overall workload). Bernard -------------------------------------------- Bernard Dautrevaux Microprocess Ingenierie 97 bis, rue de Colombes 92400 COURBEVOIE FRANCE Tel: +33 (0) 1 47 68 80 80 Fax: +33 (0) 1 47 88 97 85 e-mail: [EMAIL PROTECTED] [EMAIL PROTECTED] --------------------------------------------
patch.diff
Description: Binary data
-- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/
-- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/
