On Fri, 28 Aug 2026 22:22:29 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Add optional validation of the value of the `--linux-menu-group` option and >> desktop entry files (`*.desktop`) using the desktop-file-validate command. >> >> If the command is not available, jpackage doesn't validate the value of the >> `--linux-menu-group` option and desktop entry files it creates. >> >> It turned out that jpackage was producing desktop files that failed >> validation with some versions of the desktop-file-validate command. It was a >> minor incompatibility due to missing the trailing semicolon (;) in the value >> of the `MimeType` and `Categories` entries. Fixed accordingly. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Alexey Semenyuk has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains seven additional > commits since the last revision: > > - Fix merge error > - Merge branch 'master' into JDK-8371868 > - Improve jpackage verbose-output configuration in tests to support > environments where output is disabled. > - Validate desktop entry files created by jpackage with > desktop-file-validate command. > - ErrorTest: support tokens in error messages > - Remove redundant "return" statements. > - 8371868: Use desktop-file-validate command to validate the value of > "--linux-menu-group" option test/jdk/tools/jpackage/helpers/jdk/jpackage/test/LinuxHelper.java line 697: > 695: } > 696: > 697: var missing = > expectedValidatedDesktopEntryFileNames.stream().filter(fname -> { fname -> fileName or name. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32523#discussion_r3884514952
