On Tue, 25 Aug 2026 18:20:56 GMT, Alexey Semenyuk <[email protected]> wrote:

> Add optional validation of the value of the `--linux-menu-group` option using 
> the desktop-file-validate command.
> 
> If the command is not available, jpackage doesn't validate the value of the 
> `--linux-menu-group` option.
> 
> Additionally, this command enhances validation of desktop files created by 
> jpackage in the test code. It turned out that jpackage was producing desktop 
> files that failed validation with some versions of the desktop-file-validate 
> command. It was a minor incompatibility due to missing the trailing semicolon 
> (;) in the value of the `MimeType` and `Categories` entries. Fixed 
> accordingly.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

@sashamatveev PTAL

test/jdk/tools/jpackage/linux/ShortcutHintTest.java line 153:

> 151:     @Test
> 152:     public static void testDesktopFileFromResourceDir() throws 
> IOException {
> 153:         final String expectedTryExecDesktopEntry = "TryExec=notify-send";

`Version=12345678` doesn't pass validation with the desktop-file-validate 
command. Replaced it with a valid entry not set by jpackage.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32523#issuecomment-5418009042
PR Review Comment: https://git.openjdk.org/jdk/pull/32523#discussion_r3856984299

Reply via email to