On Fri, 28 Aug 2026 02:17:02 GMT, David Holmes <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix copyrights.
>
> src/hotspot/share/classfile/loaderConstraints.cpp line 455:
>
>> 453: if (p != nullptr && p->klass() != nullptr && p->klass() == klass) {
>> 454: // If this is the klass in the constraint, remove it.
>> 455: // Other errors during loading (eg. constraint violations) should
>> not have added this klass.
>
> "added this class" to what? Maybe just delete the comments altogether.
Yeah this is confusing. I think it was trying to say the only case that we
wouldn't have already added the klass into the loader constraint is if addClass
got an OOM, but I don't know if that's true now or will be true in the future.
I'll remove the comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32519#discussion_r3880480685
