On Thu, 27 Aug 2026 22:50:13 GMT, Coleen Phillimore <[email protected]> wrote:
>> Remove the upcall to addClass during class loading. The comment says it's >> only so GC can keep classes alive while the class loader is alive. We have >> other ways to do that. There were some JVMTI tests in the past that failed >> without this vector but today seems to be only one test. Maybe there's some >> code that has a dependency on this in heap walking. >> Tested tier1-6 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Fix copyrights. src/hotspot/share/classfile/loaderConstraints.cpp line 455: > 453: if (p != nullptr && p->klass() != nullptr && p->klass() == klass) { > 454: // If this is the klass in the constraint, remove it. > 455: // Other errors during loading (eg. constraint violations) should > not have added this klass. "added this class" to what? Maybe just delete the comments altogether. test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java line 131: > 129: // +1 referrer is classloader > 130: // +1 referrer is debugee class unloader > 131: // +1 self-reference from this_class index Are you sure that is the right comment to delete? test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java line 146: > 144: // 1 referrer is classloader > 145: // 1 referrer is debugee class unloader > 146: // 1 self-reference from this_class index Again why delete this comment? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32519#discussion_r3877399400 PR Review Comment: https://git.openjdk.org/jdk/pull/32519#discussion_r3877411101 PR Review Comment: https://git.openjdk.org/jdk/pull/32519#discussion_r3877429795
