On Tue, 21 Jul 2026 14:35:57 GMT, Guanqiang Han <[email protected]> wrote:

>> Please review this change, thanks!
>> 
>> **Description:**
>> 
>> `java -XshowSettings` without an application currently prints the requested 
>> settings, then prints usage information and exits with code 1.
>> 
>> **Solution:**
>> 
>> Treat `-XshowSettings` as an option that can be used without an application 
>> target. During argument parsing, do not mark the absence of a main class or 
>> JAR file as an error when `-XshowSettings` is specified. After the settings 
>> and any explicitly requested launcher output have been processed, exit 
>> normally if no application was provided.
>> 
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Guanqiang Han has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Adjust indentation

src/java.base/share/native/libjli/java.c line 1363:

> 1361:             !validateModules &&
> 1362:             !dumpSharedSpaces &&
> 1363:             showSettings == NULL) {

Using "!showSettings" would match the other conditions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31891#discussion_r3623231355

Reply via email to