On Tue, 21 Jul 2026 06:59:59 GMT, Guanqiang Han <[email protected]> wrote:
>> Please review this change, thanks! >> >> **Description:** >> >> `java -XshowSettings` without an application currently prints the requested >> settings, then prints usage information and exits with code 1. >> >> **Solution:** >> >> Treat `-XshowSettings` as an option that can be used without an application >> target. During argument parsing, do not mark the absence of a main class or >> JAR file as an error when `-XshowSettings` is specified. After the settings >> and any explicitly requested launcher output have been processed, exit >> normally if no application was provided. >> >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Guanqiang Han has updated the pull request incrementally with one additional > commit since the last revision: > > Update -XshowSettings description Marked as reviewed by alanb (Reviewer). src/java.base/share/native/libjli/java.c line 1360: > 1358: /* LM_UNKNOWN okay for options that exit */ > 1359: if (!listModules && !describeModule && !validateModules && > !dumpSharedSpaces && > 1360: showSettings == NULL) { The indentation makes it a bit harder to distinguish the condition from the code in the block, otherwise looks okay. ------------- PR Review: https://git.openjdk.org/jdk/pull/31891#pullrequestreview-4745610417 PR Review Comment: https://git.openjdk.org/jdk/pull/31891#discussion_r3622920341
