On Wed, 24 Jun 2026 08:01:10 GMT, Jatin Bhateja <[email protected]> wrote:
>> As per the discussion on JDK-8370691-Float16Vector Support pull request >> https://github.com/openjdk/jdk/pull/28002#issuecomment-4652163477 >> adding the handling to Canonicalize NaN lane encodings held in Float16Vector >> lanes so that all NaN representations, >> including signaling ones, computes the same hash code. >> >> Kindly review and share your feedback. >> >> Best Regards, >> Jatin >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jatin Bhateja has updated the pull request incrementally with one additional > commit since the last revision: > > Review comments resolution Very good. Much neater. Let's us run this through our testing before integrating. test/jdk/jdk/incubator/vector/Float16Vector128Tests.java line 5429: > 5427: short subarr[] = Arrays.copyOfRange(a, i, i + > SPECIES.length()); > 5428: Float16[] f16subarr = new Float16[subarr.length]; > 5429: for (int j = 0; j < subarr.length; j++) { Add a method like `toFloat16Array(short[])` as I think it will be reusable for testing the output of `toString()`, up to you or you can address it later for the `toString()` fix. ------------- PR Review: https://git.openjdk.org/jdk/pull/31587#pullrequestreview-4563889171 PR Review Comment: https://git.openjdk.org/jdk/pull/31587#discussion_r3468516869
