On Tue, 23 Jun 2026 06:01:28 GMT, Jatin Bhateja <[email protected]> wrote:
>> As per the discussion on JDK-8370691-Float16Vector Support pull request >> https://github.com/openjdk/jdk/pull/28002#issuecomment-4652163477 >> adding the handling to Canonicalize NaN lane encodings held in Float16Vector >> lanes so that all NaN representations, >> including signaling ones, computes the same hash code. >> >> Kindly review and share your feedback. >> >> Best Regards, >> Jatin >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jatin Bhateja has updated the pull request incrementally with one additional > commit since the last revision: > > Review comments resolution test/jdk/jdk/incubator/vector/Float16Vector128Tests.java line 5464: > 5462: > 5463: @Test > 5464: static void equalsNaNFloat16Vector128TestsSmokeTest() { Ideally we would also test as a non-smoke test. Can we add those two `NaN` values to the set of corner cases? That will likely shake out any more remaining issues (hopefully there are none). There is also `hashCodeFloat16Vector256TestsSmokeTest`which I think needs to be updated. Then we don't need explicit tests. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31587#discussion_r3463044858
