On Tue, 9 Jun 2026 14:35:58 GMT, Dusan Balek <[email protected]> wrote:

>> Okay but the concern with using lsof (or 
>> UnixOperatingSystemMXBean.getOpenFileDescriptorCount before/after) is that 
>> the file descriptor usage increase as a side effect of something else. I 
>> think it would require confident that it is stable in all the higher tiers, 
>> only because it's hard to get tests like this stable.
>
> I understand your concern, but note that only file descriptors associated 
> with files in the target image previously created by jlink are counted. 
> Unfortunately, I do not know of any other easy way to test this behavior.

Okay, if you've verified that it is stable when run in the high tiers where 
there is a lot more potential for interference.

On the call() method. I think it would be better if the test asserted tha the 
compiler task succeeded. If something goes wrong then it looks like it will 
pass silently.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31417#discussion_r3387565323

Reply via email to