On Tue, 9 Jun 2026 11:23:09 GMT, Alan Bateman <[email protected]> wrote:
>> Dusan Balek has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Real path used as filter > > test/langtools/tools/javac/SystemFilesClosed.java line 29: > >> 27: * @summary Check that `lib/jrt-fs.jar` and `lib/modules` are properly >> closed while >> 28: * javac is invoked with `--system` option. >> 29: * @requires os.family == "mac" | os.family == "linux" > > Is the losf usage is removed, could this test run on Windows? Yes, the use of lsof is the reason the test does not run on Windows. To make the test work on Windows, it could be modified to attempt to delete lib/modules and lib/jrt-fs.jar after compilation finishes. This would effectively verify that neither file is still open. However, this would bring us back to the requirement of knowing about the existence of lib/modules and lib/jrt-fs.jar. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31417#discussion_r3381076800
