On Wed, 20 May 2026 07:41:57 GMT, Aleksey Shipilev <[email protected]> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Various fixes
>
> src/hotspot/share/opto/divnode.cpp line 444:
> 
>> 442:   }
>> 443: 
>> 444:   // q = mul_hi(x, c) >> (s - 64) + (x < 0 ? 1 : 0) = mul_hi(x, c) >> 
>> (x - 64) - (x >> 63)
> 
> `>> (x - 64) - (x >> 63)` -- the first one should be `(s - 64)`, correct?

Thanks for noticing, I have fixed the PR according to your suggestions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31033#discussion_r3272169147

Reply via email to