On Tue, 5 May 2026 05:32:20 GMT, Quan Anh Mai <[email protected]> wrote:

> Hi,
> 
> I was reminded of this forgotten PR when reviewing a counted loop 
> transformation PR. The important point is that it is easier and more 
> efficient to compute the trip count of a counted loop using unsigned 
> division. Currently, for int counted loops, trip count is computed by 
> extending the loop parameters to long and doing a signed long division. This 
> cannot be applied to long counted loop. As a result, as a precondition for 
> long counted loop predication, we need to be able to efficiently transform an 
> unsigned division by constant.
> 
> For more information, please refer to #9947 .
> 
> Testing:
> 
> - [x] tier1-4,hs-comp-stress
> 
> Please take a look and leave your review, thanks a lot.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

test/hotspot/jtreg/compiler/c2/irTests/DivINodeIdealizationTests.java line 42:

> 40:     @Run(test = {"constant", "identity", "identityAgain", "identityThird",
> 41:                  "retainDenominator", "divByNegOne", "divByPow2And",
> 42:                  "divByPow2And1",  "divByPow2", "divByNegPow2", 
> "divByMin",

Suggestion:

                 "divByPow2And1", "divByPow2", "divByNegPow2", "divByMin",

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31033#discussion_r3187416147

Reply via email to