On Fri, 13 Mar 2026 13:35:24 GMT, Damon Fenacci <[email protected]> wrote:
>> Volkan Yazici has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains nine additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/master' into sU16
>> - Replace `RETURN_ON_BAILOUT` with two methods
>> - Move `if (stopped())` into `while (0)`
>> - `with_opaque` of `generate_string_range_check` become redundant, remove it
>> - Sharpen class visibility
>> - Guard `getChars()`
>> - Guard `toBytes()`
>> - Factor bailing logic in `generate_string_range_check` out
>> - Document `getChar`/`putChar`
>
> src/hotspot/share/opto/library_call.cpp line 857:
>
>> 855: Node* frame = _gvn.transform(new ParmNode(C->start(),
>> TypeFunc::FramePtr));
>> 856: Node* halt = _gvn.transform(new HaltNode(bailout, frame,
>> "unexpected guard failure in intrinsic"));
>> 857: C->root()->add_req(halt); \
>
> Suggestion:
>
> C->root()->add_req(halt);
Fixed in 0f5f0a342f8.
> src/hotspot/share/opto/library_call.cpp line 1558:
>
>> 1556: if (too_many_traps(Deoptimization::Reason_intrinsic)) {
>> 1557: return false;
>> 1558: }
>
> I think this can be removed as we don't emit an uncommon trap anymore.
Removed in 0f5f0a342f8.
> src/hotspot/share/opto/library_call.cpp line 1643:
>
>> 1641: if (too_many_traps(Deoptimization::Reason_intrinsic)) {
>> 1642: return false;
>> 1643: }
>
> It can be removed too.
Removed in 0f5f0a342f8.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30139#discussion_r2939823107
PR Review Comment: https://git.openjdk.org/jdk/pull/30139#discussion_r2939844958
PR Review Comment: https://git.openjdk.org/jdk/pull/30139#discussion_r2939845494
