On Fri, 13 Mar 2026 17:40:56 GMT, Volkan Yazici <[email protected]> wrote:
>> Volkan Yazici has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains nine additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/master' into sU16
>> - Replace `RETURN_ON_BAILOUT` with two methods
>> - Move `if (stopped())` into `while (0)`
>> - `with_opaque` of `generate_string_range_check` become redundant, remove it
>> - Sharpen class visibility
>> - Guard `getChars()`
>> - Guard `toBytes()`
>> - Factor bailing logic in `generate_string_range_check` out
>> - Document `getChar`/`putChar`
>
> src/hotspot/share/opto/library_call.cpp line 1143:
>
>> 1141: if (too_many_traps(Deoptimization::Reason_intrinsic)) {
>> 1142: return false;
>> 1143: }
>
> @dafedafe, can this be removed too?
It looks OK.
> src/hotspot/share/opto/library_call.cpp line 1288:
>
>> 1286: if (too_many_traps(Deoptimization::Reason_intrinsic)) {
>> 1287: return false;
>> 1288: }
>
> @dafedafe, do we still need this too?
This one too.
> src/hotspot/share/opto/library_call.cpp line 1391:
>
>> 1389: if (too_many_traps(Deoptimization::Reason_intrinsic)) {
>> 1390: return false;
>> 1391: }
>
> @dafedafe, this one?
Not this one: there is an `uncommon_trap` below.
> src/hotspot/share/opto/library_call.cpp line 1464:
>
>> 1462: if (too_many_traps(Deoptimization::Reason_intrinsic)) {
>> 1463: return false;
>> 1464: }
>
> @dafedafe, what about this one?
This one too.
Note: I made a rough check of the code after the three `too_many_traps` checks
that can be removed. It should be OK to remove them but it would be good if you
could have another pass as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30139#discussion_r2938769043
PR Review Comment: https://git.openjdk.org/jdk/pull/30139#discussion_r2938770279
PR Review Comment: https://git.openjdk.org/jdk/pull/30139#discussion_r2938758777
PR Review Comment: https://git.openjdk.org/jdk/pull/30139#discussion_r2938801033
