On Fri, 9 Jan 2026 00:26:17 GMT, Sandhya Viswanathan <[email protected]> wrote:
>> Mohamed Issa has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Also update copyright year in IREncodingPrinter.java > > src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1056: > >> 1054: } >> 1055: jcc(Assembler::equal, DONE_LABEL); // handle special case >> +0.0/-0.0, if argument is +0.0/-0.0, return argument >> 1056: jcc(Assembler::parity, DONE_LABEL); // handle special case NaN, >> if argument NaN, return NaN > > It looks to me that these two could be replaced by one jcc. > For with AVX 10.2: > jcc if Sign flag is set to DONE_LABEL > For without AVX 10.2: > jcc if equal to DONE_LABEL Yes, that would work. The code becomes a little more cryptic, but it should be fine with enough explanation in the comments. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28337#discussion_r2674435533
