On Thu, 11 Dec 2025 23:33:41 GMT, Mohamed Issa <[email protected]> wrote:
>> src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp line 2069:
>>
>>> 2067: } else {
>>> 2068: __ ucomiss(reg1, opr2->as_xmm_float_reg());
>>> 2069: }
>>
>> Please create a new macro assembly routine for this if-else idiom, its
>> getting repeated multiple times.
>
> FYI, this portion could be split into a separate PR. However, I created a
> couple of macros so that you can check and verify if they match what you are
> thinking of.
I moved the logic out of this PR. I'll create another one containing it that
will be linked to [JDK-8373834](https://bugs.openjdk.org/browse/JDK-8373834).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28337#discussion_r2670502059
