On Mon, 5 Jan 2026 17:41:31 GMT, David Beaumont <[email protected]> wrote:
>> Remove ineffective/unused ImageBufferCache class, and simplify callers / >> remove dead code. >> >> I removed the release methods in the internal classes, but the public >> ModuleReader API method is still there (the override can go away though >> since the default implementation also tests for non-null, so removing the >> override has no risk). >> >> I suspect there are no implementations of ModuleReader that implement >> release semantics after this change, so perhaps we could relax the >> documentation around it? Thoughts welcome. > > David Beaumont has updated the pull request incrementally with one additional > commit since the last revision: > > actually remove the class ... > I suspect there are no implementations of ModuleReader that implement release > semantics after this change, so perhaps we could relax the documentation > around it? Thoughts welcome. I think we should leave the API docs as is as it allows for a ModuleReader to use off-heap memory in the future. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29043#issuecomment-3711830260
