> Remove ineffective/unused ImageBufferCache class, and simplify callers / > remove dead code. > > I removed the release methods in the internal classes, but the public > ModuleReader API method is still there (the override can go away though since > the default implementation also tests for non-null, so removing the override > has no risk). > > I suspect there are no implementations of ModuleReader that implement release > semantics after this change, so perhaps we could relax the documentation > around it? Thoughts welcome.
David Beaumont has updated the pull request incrementally with one additional commit since the last revision: actually remove the class ... ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29043/files - new: https://git.openjdk.org/jdk/pull/29043/files/2b158fe4..5a37317e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29043&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29043&range=00-01 Stats: 158 lines in 1 file changed: 0 ins; 158 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/29043.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29043/head:pull/29043 PR: https://git.openjdk.org/jdk/pull/29043
