On Wed, 26 Nov 2025 05:02:05 GMT, Alexey Semenyuk <[email protected]> wrote:

>> Maybe. I am getting following error without it:
>> 
>> java.lang.AssertionError: Expected [2]. Actual [1]: Check the package has 2 
>> top installation directories
>>      at jdk.jpackage.test.TKit.error(TKit.java:369)
>>      at jdk.jpackage.test.TKit.assertEquals(TKit.java:720)
>>      at 
>> jdk.jpackage.test.PackageTest$Handler.verifyRootCountInUnpackedPackage(PackageTest.java:858)
>> 
>> I need to investigate it.
>
> Looks like in the case of predefined app image packaging, when 
> "--mac-app-store" is used with the predefined app image but not used in the 
> terminal packaging command, jpackage still adds service files to the package. 
> Looks like a bug.
> 
> We added "mac-app-store" property to the app image file in 
> [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850). Do we still need 
> it? Why do we want to know that the predefined app image was created with 
> "--mac-app-store" option? In app image bundling, this option affects signing 
> identities only, right?

It is a bug in verification code. Test thinks that we should have 2 top 
installation directory, but we got 1. This is expected since predefined app 
image was generated with "--mac-app-store".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28487#discussion_r2565681263

Reply via email to