Re: RFR: 8351095: [macos] Add more jpackage tests for --mac-app-store option [v3]

[Alexander Matveev]

On Wed, 26 Nov 2025 03:52:38 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8351095: [macos] Add more jpackage tests for --mac-app-store option [v3]
>
> test/jdk/tools/jpackage/share/ServiceTest.java line 267:
> 
>> 265:                     if (isMacAppStore) {
>> 266:                         cmd.addArgument("--mac-app-store");
>> 267:                     }
> 
> Do we still need this change?

Maybe. I am getting following error without it:

java.lang.AssertionError: Expected [2]. Actual [1]: Check the package has 2 top 
installation directories
        at jdk.jpackage.test.TKit.error(TKit.java:369)
        at jdk.jpackage.test.TKit.assertEquals(TKit.java:720)
        at 
jdk.jpackage.test.PackageTest$Handler.verifyRootCountInUnpackedPackage(PackageTest.java:858)

I need to investigate it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28487#discussion_r2562960147