On Thu, 13 Nov 2025 18:58:48 GMT, Jorn Vernee <[email protected]> wrote:
>> Per Minborg has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Remove lingering comment
>> - Refactor and use long arrays
>> - Remove BulkOps
>
> test/micro/org/openjdk/bench/java/lang/foreign/SegmentBulkFill.java line 114:
>
>> 112: segment = switch (SegmentType.valueOf(segmentType)) {
>> 113: case HEAP -> heapSegment;
>> 114: case NATIVE -> Arena.ofAuto().allocateFrom(JAVA_LONG,
>> heapSegment, JAVA_LONG, 0L, baseArray.length);
>
> Suggestion:
>
> case NATIVE -> Arena.ofAuto().allocateFrom(JAVA_LONG,
> baseArray);
(and same for the other 2)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28260#discussion_r2524601213
