On Wed, 12 Nov 2025 09:08:10 GMT, Per Minborg <[email protected]> wrote:

> This PR proposes to consolidate and standardize the benchmarks related to the 
> bulk operations for memory segments. 
> 
> All the benchmarks will now run with 
> (heap|native)x(aligned|unaligned)x(intint|intlong|longlong) combinations.
> 
> It should be noted that with this change, the running time for the benchmarks 
> would increase significantly.

Drive by comment for now. Nice effort, to unify the benchmarks :)

test/micro/org/openjdk/bench/java/lang/foreign/SegmentBulkMismatch.java line 
122:

> 120:                     srcSegment = srcSegment.asSlice(1, size);
> 121:                     dstSegment = dstSegment.asSlice(1, size);
> 122:                 }

What do you hope to acheive with this? I hope that the intrinsics automatically 
align the vectors, right? Or are you checking for exactly that?

-------------

PR Review: https://git.openjdk.org/jdk/pull/28260#pullrequestreview-3453489287
PR Review Comment: https://git.openjdk.org/jdk/pull/28260#discussion_r2518338346

Reply via email to