On Tue, 11 Nov 2025 19:18:35 GMT, Lance Andersen <[email protected]> wrote:
>> Christian Stein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move manifest location check to after the order mismatch validation > > test/jdk/tools/jar/ValidatorTest.java line 342: > >> 340: } >> 341: >> 342: private void testWrongManifestPosition( > > This new test only validates that the LOC MANIFEST.MF entries are where they > need to be. It does not do a similar CEN check in the event that the LOC and > CEN entries do not match. > > If you change your validation order so that Validator checks the MANIFEST > location after it checks the order, then you should be covered. > > I would also add a comment to the test to help future maintainers to the test > ... I'll add such a comment. The existing tests for LOC-CEN related mismatches should already cover those cases. In addition, the results of the checks in `Validator` are accumulated - so their order is not important, right? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28154#discussion_r2517154697
