On Mon, 10 Nov 2025 17:58:25 GMT, Lance Andersen <[email protected]> wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move manifest location check to after the order mismatch validation
>
> src/jdk.jartool/share/classes/sun/tools/jar/Validator.java line 257:
>
>> 255:
>> errorAndInvalid(formatMsg("error.validator.wrong.position", firstName, "0"));
>> 256: }
>> 257: }
>
> I would suggest to move this check to after the order mismatch validation
> below as the checks also validate if the manifest is missing in the LOC or
> CEN or out of order
>
> By doing so you will also guarantee that Manifest is at the same offset it
> both he LOC and CEN
Applied by
https://github.com/openjdk/jdk/commit/9986cd87d732ed899d9a6300951f6e65d6a12eeb
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28154#discussion_r2515365378
