On Mon, 6 Oct 2025 22:30:21 GMT, Patricio Chilano Mateo 
<[email protected]> wrote:

>> test/jdk/java/lang/Thread/virtual/MonitorWaitNotify.java line 645:
>> 
>>> 643:     /**
>>> 644:      * Test no deadlock happens when Object.wait is called from a mix 
>>> of pinned and non-pinned
>>> 645:      * paths and notification is done using notifyAll.
>> 
>> At some point then maybe we should combine this with 
>> RetryMonitorEnterWhenPinned. I'm not suggesting we do this now but some of 
>> the expanded description might be useful to include here as a passing reader 
>> might not immediately know what this test is doing.
>
> I wasn’t sure where to put the extra test and missed 
> `RetryMonitorEnterWhenPinned.java`. I agree it makes more sense to have it 
> there. Moved now, let me know what you think.

Thanks for moving to RetryMonitorEnterWhenPinned as it is similar to the test 
we had for enter. The update, and conversion to JUnit look good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27597#discussion_r2423388839

Reply via email to