On Mon, 6 Oct 2025 16:48:35 GMT, Alan Bateman <[email protected]> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> make MAX_RECHECK_INTERVAL global static
>
> test/jdk/java/lang/Thread/virtual/MonitorWaitNotify.java line 645:
>
>> 643: /**
>> 644: * Test no deadlock happens when Object.wait is called from a mix
>> of pinned and non-pinned
>> 645: * paths and notification is done using notifyAll.
>
> At some point then maybe we should combine this with
> RetryMonitorEnterWhenPinned. I'm not suggesting we do this now but some of
> the expanded description might be useful to include here as a passing reader
> might not immediately know what this test is doing.
I wasn’t sure where to put the extra test and missed
`RetryMonitorEnterWhenPinned.java`. I agree it makes more sense to have it
here. Moved now, let me know what you think.
> test/jdk/java/lang/Thread/virtual/MonitorWaitNotify.java line 648:
>
>> 646: */
>> 647: @Test
>> 648: void testMixedPinnedUnmounted() throws Exception {
>
> What would you think of testing timed-wait too? Some of the other tests are
> paramerized with a value source and some time values to test both untimed and
> timed waits.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27597#discussion_r2408849669
PR Review Comment: https://git.openjdk.org/jdk/pull/27597#discussion_r2408850049
