On Wed, 8 Oct 2025 17:51:59 GMT, Alexey Semenyuk <[email protected]> wrote:
> - Validate "libjli.dylib" file in the "lib" directory referenced with the
> `--runtime-image` option.
> - Split "ERR_MissingJLinkOptMacAppStore" error key into
> "error.invalid-runtime-image-bin-dir" and
> "error.invalid-runtime-image-bin-dir.advice"; moved new keys to mac-specific
> string property file.
> - Fix a couple of typos in RuntimeBuilderBuilder and WixSourceConverter
> classes.
>
> Error messages:
>
> Runtime image "ErrorTest/test.85b994e1/empty-runtime-image" is missing
> "lib/**/libjli.dylib" file
>
> Runtime image "ErrorTest/test.05a7421a/invalid-runtime-bundle" is missing
> "Contents/Home/lib/**/libjli.dylib" file
>
> Runtime image "/Users/alexeysemenyuk/jpackage-dev-runtime" should not contain
> "bin" folder
> Advice to fix: Use --strip-native-commands jlink option when generating
> runtime image used with --mac-app-store option
test/jdk/tools/jpackage/share/ErrorTest.java line 102:
> 100: return root.toString();
> 101: })),
> 102: EMPTY_DIR(toFunction(cmd -> {
It is good idea to test `EMPTY_DIR`, but I think we should test one with `lib`
subdirectory and at least one file in it to cover all code paths.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27701#discussion_r2415126716
