On Wed, 8 Oct 2025 22:55:46 GMT, Alexey Semenyuk <[email protected]> wrote:
>> test/jdk/tools/jpackage/share/ErrorTest.java line 102:
>>
>>> 100: return root.toString();
>>> 101: })),
>>> 102: EMPTY_DIR(toFunction(cmd -> {
>>
>> It is good idea to test `EMPTY_DIR`, but I think we should test one with
>> `lib` subdirectory and at least one file in it to cover all code paths.
>
> Agreed. I'll do that
New errors in ErrorTest:
Bundler Mac Application Image skipped because of a configuration problem:
Runtime image "ErrorTest/test.f7b24e53/empty-dir" is missing
"lib/**/libjli.dylib" file
Bundler Mac Application Image skipped because of a configuration problem:
Runtime image "ErrorTest/test.05a7421a/mac-invalid-runtime-bundle" is missing
"Contents/Home/lib/**/libjli.dylib" file
Bundler Mac Application Image skipped because of a configuration problem:
Runtime image "ErrorTest/test.40e41dd5/mac-invalid-runtime-image" is missing
"lib/**/libjli.dylib" file
Bundler Mac DMG Package skipped because of a configuration problem: Runtime
image "ErrorTest/test.3902d173/empty-dir" is missing "lib/**/libjli.dylib" file
Bundler Mac DMG Package skipped because of a configuration problem: Runtime
image "ErrorTest/test.c1f9053a/mac-invalid-runtime-bundle" is missing
"Contents/Home/lib/**/libjli.dylib" file
Bundler Mac DMG Package skipped because of a configuration problem: Runtime
image "ErrorTest/test.626020f5/mac-invalid-runtime-image" is missing
"lib/**/libjli.dylib" file
Bundler Mac DMG Package skipped because of a configuration problem: Runtime
image "ErrorTest/test.ad0f34dc/empty-dir" is missing "lib/**/libjli.dylib" file
Bundler Mac DMG Package skipped because of a configuration problem: Runtime
image "ErrorTest/test.740392a3/mac-invalid-runtime-bundle" is missing
"Contents/Home/lib/**/libjli.dylib" file
Bundler Mac DMG Package skipped because of a configuration problem: Runtime
image "ErrorTest/test.b19ca05e/mac-invalid-runtime-image" is missing
"lib/**/libjli.dylib" file
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27701#discussion_r2417284294
