On Mon, 29 Sep 2025 09:24:22 GMT, Volkan Yazici <[email protected]> wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> RemoveFields(duration) and filter internal frames
>
> test/jdk/java/lang/reflect/Field/mutateFinals/cli/CommandLineTest.java line
> 190:
>
>> 188: @Test
>> 189: void testLastOneWins() throws Exception {
>> 190: test("testFieldSetInt", "--illegal-final-field-mutation=allow",
>> "--illegal-final-field-mutation=deny")
>
> This tests `setProperty+Defaults`. Shall we also test `setProperty+vmOpt`?
It wouldn't do any harm to have this test exercise another combination. The
simplest one to add is where the winner specifies "warn" or "debug" as the
output can be checked.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25115#discussion_r2390468743
