On Mon, 29 Sep 2025 10:09:44 GMT, Volkan Yazici <[email protected]> wrote:

>> Alan Bateman has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   RemoveFields(duration) and filter internal frames
>
> test/jdk/java/lang/reflect/Field/mutateFinals/jar/ExecutableJarTest.java line 
> 121:
> 
>> 119:     }
>> 120: 
>> 121:     /**
> 
> Why don't we verify the output (i.e., no warnings) in this case?

These two run with `--illegal-final-field-mutation=deny` and are testing that 
Enable-Final-Field-Mutation: ALL-UNNAMED is effective. They could also test 
that there aren't any warnings but this is secondary.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25115#discussion_r2391342932

Reply via email to