On Thu, 9 Oct 2025 13:50:23 GMT, Alan Bateman <[email protected]> wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> MethodParameters attribute should not be removed
>
> test/jdk/tools/jlink/plugins/StripParameterNamesTest.java line 67:
>
>> 65: private static List<Jmod> testJmods = new ArrayList<>();
>> 66:
>> 67: record Jmod(Path moduleDir, boolean withDebugInfo, boolean
>> withParameterNames) {}
>
> Is the withDebugInfo component used?
Not at this point, as we don't try to verify debug info simply because we have
that covered in StripJavaDebugAttributesPluginTest.java.
I can remove it if we like, it describes how the jmod was built.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27566#discussion_r2417625517
