> Since parameters is an opt-in choice, it's more reasonable to consider that's 
> desired information and make strip parameter names an opt-in choice as well.
> 
> This PR changes the default behavior of --strip-debug to keep parameter names 
> when it's available. Add opt-in mechanism,
> via the strip-java-debug-attributes plugin by using argument 
> `--strip-java-debug-attributes=+parameter-names`.
> 
> The --strip-debug option is a little bit odd, as it's a main option as well 
> as a plugin option to enable the DefaultStripDebugPlugin, which strip native 
> debug information on platform support the feature, and strip java debug 
> information. In this PR, we chose to support only one mechanism to enable 
> strip parameter names, so we would disable the embed 
> StripJavaDebugAttributesPlugin when StripJavaDebugAttributesPlugin is enabled.
> 
> The StripParameterNamesTest illustrate and verify parameter names use cases, 
> mainly focus on argument processing and the parameter names. We didn't verify 
> the regular debug info as that's covered by existing test.

Henry Jen has updated the pull request incrementally with one additional commit 
since the last revision:

  MethodParameters attribute should not be removed

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/27566/files
  - new: https://git.openjdk.org/jdk/pull/27566/files/8b5a6c12..766dc01e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=27566&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=27566&range=01-02

  Stats: 126 lines in 5 files changed: 1 ins; 108 del; 17 mod
  Patch: https://git.openjdk.org/jdk/pull/27566.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/27566/head:pull/27566

PR: https://git.openjdk.org/jdk/pull/27566

Reply via email to